Commit 0eea6923 authored by James Cross's avatar James Cross Committed by Facebook Github Bot
Browse files

fix make_positions() typo (#316) 

Summary:
Pull Request resolved: https://github.com/pytorch/fairseq/pull/316

This code should actually be keeping the padded positions as `padding_idx` (though note that this is on the ONNX export path, and it has no effect in the most common case when using the exported network to do un-batched inference).

Reviewed By: myleott

Differential Revision: D10431872

fbshipit-source-id: 79fe4ac27cafcd4701e0f2a90e29d1b7362dc6f8
parent e286243c

fairseq/utils.py

+1 −1
Original line number Diff line number Diff line
@@ -312,7 +312,7 @@ def make_positions(tensor, padding_idx, left_pad, onnx_trace=False): 
        positions = range_buf.expand_as(tensor)

        if left_pad:

            positions = positions - mask.size(1) + mask.long().sum(dim=1).unsqueeze(1)

        return positions * mask.long() + positions * (1 - mask.long())

        return positions * mask.long() + padding_idx * (1 - mask.long())



    max_pos = padding_idx + 1 + tensor.size(1)

    if not hasattr(make_positions, 'range_buf'):