Unverified Commit 6e4d370a authored by Myle Ott's avatar Myle Ott Committed by GitHub
Browse files

More updates for PyTorch (#114)

parent 3bde773d

fairseq/models/lstm.py

+3 −3
Changes for fairseq/models/lstm.py: 3 added lines, 3 removed lines.
Original line number Diff line number Diff line
@@ -96,9 +96,9 @@ class LSTMEncoder(FairseqEncoder): 
    def forward(self, src_tokens, src_lengths):

        if LanguagePairDataset.LEFT_PAD_SOURCE:

            # convert left-padding to right-padding

            src_tokens.data = utils.convert_padding_direction(

                src_tokens.data,

                src_lengths.data,

            src_tokens = utils.convert_padding_direction(

                src_tokens,

                src_lengths,

                self.padding_idx,

                left_to_right=True,

            )

fairseq/utils.py

+0 −2
Changes for fairseq/utils.py: 0 added lines, 2 removed lines.
Original line number Diff line number Diff line
@@ -289,8 +289,6 @@ def convert_padding_direction( 
    right_to_left=False,

    left_to_right=False,

):

    assert not isinstance(src_tokens, Variable)

    assert not isinstance(src_lengths, Variable)

    assert right_to_left ^ left_to_right

    pad_mask = src_tokens.eq(padding_idx)

    if pad_mask.max() == 0:

requirements.txt

+1 −1
Changes for requirements.txt: 1 added line, 1 removed line.
Original line number Diff line number Diff line 
cffi

numpy

torch>=0.4.0

torch

tqdm

tests/test_utils.py

+1 −1
Changes for tests/test_utils.py: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -61,7 +61,7 @@ class TestUtils(unittest.TestCase): 


    def assertAlmostEqual(self, t1, t2):

        self.assertEqual(t1.size(), t2.size(), "size mismatch")

        self.assertLess((t1 - t2).abs().max(), 1e-4)

        self.assertLess(utils.item((t1 - t2).abs().max()), 1e-4)





if __name__ == '__main__':