From 176c53cb1b1c4b94faf485d74efc4577dae5bc7e Mon Sep 17 00:00:00 2001
From: Simon Will <will@cl.uni-heidelberg.de>
Date: Fri, 2 Apr 2021 12:46:06 +0200
Subject: [PATCH] Save 2 out of 5 pieces of feedback in the dev split

---
 joeynmt_server/views/feedback.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/joeynmt_server/views/feedback.py b/joeynmt_server/views/feedback.py
index 6629052..50b6d51 100644
--- a/joeynmt_server/views/feedback.py
+++ b/joeynmt_server/views/feedback.py
@@ -35,9 +35,8 @@ def save_feedback():
     db.session.commit()
 
     if not split_was_explicitly_set:
-        if fb.id % 5 == 0:
-            fb.split = 'test'
-        elif fb.id % 5 == 4:
+        # Out of five pieces of feedback, number 4 and 5 are saved as dev
+        if fb.id % 5 in [0, 4]:
             fb.split = 'dev'
         db.session.commit()
 
-- 
GitLab