Skip to content
Snippets Groups Projects
Unverified Commit 399679d1 authored by karp's avatar karp
Browse files

Fix SQLAlchemy-related type errors

parent 9e0cbaed
No related branches found
No related tags found
1 merge request!27Update pipeline to check types and formatting
Pipeline #6732 passed with warnings
...@@ -9,7 +9,7 @@ from flask_sqlalchemy import SQLAlchemy ...@@ -9,7 +9,7 @@ from flask_sqlalchemy import SQLAlchemy
from .db_config import get_database_uri, get_uri_for_sqlite from .db_config import get_database_uri, get_uri_for_sqlite
db = SQLAlchemy() db: SQLAlchemy = SQLAlchemy()
from .model import * from .model import *
......
from flask import Flask from flask import Flask
from typing import Any
from portal import db from portal import db
BaseModel: Any = db.Model
class FlaskConfigEntry(db.Model):
class FlaskConfigEntry(BaseModel):
""" """
A configuration entry for Flask (a key-value pair) as persisted in a database A configuration entry for Flask (a key-value pair) as persisted in a database
""" """
......
from abc import abstractmethod from abc import abstractmethod
from typing import Any, List, Optional, Self from typing import Any, List, Optional, Self
from sqlalchemy import Column
from flask import g from flask import g
from portal import db from portal import db
BaseModel: Any = db.Model
class Retrievable(db.Model):
class Retrievable(BaseModel):
""" """
A type whose instances can be retrieved from the database. A type whose instances can be retrieved from the database.
...@@ -17,7 +20,7 @@ class Retrievable(db.Model): ...@@ -17,7 +20,7 @@ class Retrievable(db.Model):
__abstract__ = True __abstract__ = True
@classmethod @classmethod
def get_canonical_order_column(cls) -> Optional[db.Column]: def get_canonical_order_column(cls) -> Optional[Column]:
""" """
Return the colum by which instances of this type should be canonically ordered Return the colum by which instances of this type should be canonically ordered
when retrieving them all from the database. when retrieving them all from the database.
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment