Make MyPy happy (!22) · Merge requests · Fachschaft / Portal

Merged karp requested to merge make-mypy-happy into master 7 months ago

Aug 17, 2024
- Route may not necessarily return a ProblemResponse · e1c153f0
  Jakob Moser authored 7 months ago
  
  Verified
  
  e1c153f0
- Rearrange lines (first "assert" authorization type, then check payload) · c40f2ff0
  Jakob Moser authored 7 months ago
  
  Verified
  
  c40f2ff0
- Use Optional, remove incorrect type · 4dcb6d31
  Jakob Moser authored 7 months ago
  
  Verified
  
  4dcb6d31
- Make annotation more specific · 59bbca69
  Jakob Moser authored 7 months ago
  
  Verified
  
  59bbca69
- Remove likely unneeded annotation · 44d9fde1
  Jakob Moser authored 7 months ago
  
  db = SQLAlchemy() should be enough to already infer the type of the variable
  Verified
  
  44d9fde1
- Make annotation for parameter more specific · e2e69b26
  Jakob Moser authored 7 months ago
  
  Verified
  
  e2e69b26
- Use Optional instead of | None for consistency · 7fa961af
  Jakob Moser authored 7 months ago
  
  Verified
  
  7fa961af
- Add some more descriptive type aliases · 3098ca66
  Jakob Moser authored 7 months ago
  
  Verified
  
  3098ca66
- Fix typing in UtcDateTime and Uuid · de55edc5
  karp authored 7 months ago
  
  Update to solve the LSP errors via typing changes and not by code changes. This undos LSP-violation related code changes.
  Unverified
  
  de55edc5
Aug 07, 2024

Fix annotation in UtcDateTime#process_result_value · 4e80c09a
karp authored 7 months ago
```
The argument can only be a string or None, because
dateime.from_isoformat expects only a string.
```
Unverified

4e80c09a

Fix LSP error in UtcDateTime#process_bind_param · b0b1703f

karp authored 7 months ago

According to mypy the previous annotation violated the LSP.
We now use the types of the supertype method and return a
datetime object only if the argument was a datetime-object.

Unverified

b0b1703f

Fix type annotation of UUID · aa6c5152

karp authored 7 months ago

According to mypy the previous annotation violated the LSP.
Therefore, we use the types of the supertype method and check for
correct types in the method.

Unverified

aa6c5152

Add missing type declarations · 9df2b5d6
karp authored 7 months ago

Unverified

9df2b5d6

Make MyPy happy

Merge request reports

Activity