Skip to content
Snippets Groups Projects

Make MyPy happy

Merged Make MyPy happy
make-mypy-happy into master
All threads resolved!
Merged karp requested to merge make-mypy-happy into master
All threads resolved!
Viewing commit aa6c5152
Prev Next
Show latest version
1 file
+ 2
− 2
Compare changes
  • Side-by-side
  • Inline
  • aa6c5152
    karp
    Fix type annotation of UUID · aa6c5152
    karp authored 
    According to mypy the previous annotation violated the LSP.
Therefore, we use the types of the supertype method and check for
correct types in the method.
portal/model/Uuid.py
+ 3
− 1
@@ -26,7 +26,9 @@ class Uuid(types.TypeDecorator):
def load_dialect_impl(self, dialect: Dialect) -> types.TypeEngine[Any]:
return types.String(UUID_LENGTH)
def process_bind_param(self, value: str | UUID, dialect: Dialect) -> Optional[str]:
def process_bind_param(
self, value: Optional[str | UUID], dialect: Dialect
) -> Optional[str]:
if isinstance(value, str):
# Manually create UUID from string, to raise an error if the string is malformed
UUID(value)