Update pipeline to check types and formatting
Merge request reports
Activity
added 1 commit
- 2576afc0 - Update pipeline to check types and formatting
The type declarations are based on https://stackoverflow.com/questions/63542818/mypy-and-inheriting-from-a-class-that-is-an-attribute-on-an-instance.
assigned to @karp
requested review from @moser
Looks nice, thanks!
Two requests:
- Could you (if not already done) explain in the README how to achieve compliance (i.e. run black and check types)?
- Could you make this pipeline step optional (i.e. that failure only produces a warning), please? Personally, I think enforcing correct typing is a good thing; however, Portal is currently the one project with contributors that aren't just me, and I do not want to introduce additional hurdles for them.
Edited by karp-
I disagree with your second request, even though I see your point. In my humble opinion, enforcing correct types helps not to accidentally break something, which is helpful to other contributors and not an additional hurdle. It is intended to guarantee a baseline of quality when code is merged into the
master-branch.Edited by karp mentioned in commit 2104d99f
mentioned in commit 699ce15b
mentioned in merge request !25 (merged)
Please register or sign in to reply