Commit 5869385c authored by Louis MARTIN's avatar Louis MARTIN Committed by Facebook Github Bot
Browse files

Try to access sys.stdin.fileno() only at runtime and not during import (#553) 

Summary:
Accessing sys.stdin.fileno() raises an error in multiple contexts
(pytest, joblib, jupyter...).
Thus accessing it at the top level of the file can cause other scripts
to crash when they import fairseq.
This is why it is moved inside the method of MultiprocessingPdb to only
be accessed at runtime if needed.

See  Issue #517
Pull Request resolved: https://github.com/pytorch/fairseq/pull/553

Differential Revision: D14309284

Pulled By: myleott

fbshipit-source-id: 6ca36f2053a86ebc02e2d6f025459c6a78c592e7
parent 2ad1178e

fairseq/pdb.py

+5 −1
Original line number Diff line number Diff line
@@ -14,9 +14,12 @@ import sys 
__all__ = ['set_trace']





_stdin_fd = sys.stdin.fileno()

_stdin = [None]

_stdin_lock = multiprocessing.Lock()

try:

    _stdin_fd = sys.stdin.fileno()

except Exception:

    _stdin_fd = None





class MultiprocessingPdb(pdb.Pdb):
@@ -32,6 +35,7 @@ class MultiprocessingPdb(pdb.Pdb): 
        stdin_bak = sys.stdin

        with _stdin_lock:

            try:

                if _stdin_fd is not None:

                    if not _stdin[0]:

                        _stdin[0] = os.fdopen(_stdin_fd)

                    sys.stdin = _stdin[0]