Commit cefe3f8a authored by Davide Caroselli's avatar Davide Caroselli Committed by Facebook Github Bot
Browse files

Fixed wrong help message shown on '--help' (#446) 

Summary:
Correct help message was obfuscated by the transient `ArgumentParser` used only for eagerly read `--user-dir` flag.

To reproduce just try:
```bash
python3 train.py --help
```
Pull Request resolved: https://github.com/pytorch/fairseq/pull/446

Differential Revision: D13674731

Pulled By: myleott

fbshipit-source-id: b9503a4d7ef26405be630d31c0ca02386d783031
parent ebaf8c50

fairseq/options.py

+1 −1
Original line number Diff line number Diff line
@@ -124,7 +124,7 @@ def parse_args_and_arch(parser, input_args=None, parse_known=False): 
def get_parser(desc, default_task='translation'):

    # Before creating the true parser, we need to import optional user module

    # in order to eagerly import custom tasks, optimizers, architectures, etc.

    usr_parser = argparse.ArgumentParser()

    usr_parser = argparse.ArgumentParser(add_help=False)

    usr_parser.add_argument('--user-dir', default=None)

    usr_args, _ = usr_parser.parse_known_args()